Skip to content

improve Onboarding Flow for Program Creation - #2778

Merged
adelowo merged 18 commits into
mainfrom
feat-ISS-2880
Sep 13, 2026
Merged

improve Onboarding Flow for Program Creation#2778
adelowo merged 18 commits into
mainfrom
feat-ISS-2880

Conversation

@adelowo

@adelowo adelowo commented Sep 10, 2026

Copy link
Copy Markdown
Member

create the actual program + controls instead of just leaving tasks behind asking users to create them

@adelowo
adelowo marked this pull request as ready for review September 10, 2026 13:18
@adelowo
adelowo requested a review from a team as a code owner September 10, 2026 13:18
@adelowo
adelowo enabled auto-merge (squash) September 10, 2026 13:19
Comment thread internal/ent/hooks/onboarding.go Outdated
Comment thread internal/ent/hooks/onboarding_program.go Outdated
Comment thread internal/ent/hooks/onboarding_program.go Outdated
Comment thread internal/ent/hooks/onboarding_program.go Outdated
Comment thread internal/ent/hooks/onboarding.go Outdated
)

// init registers the campaign recurring listeners so gala setup picks them up automatically
func init() { registerListeners(CampaignRecurringListeners) }

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you delete all these? This was to prevent having to go to another file to remember to register them, and it can just be done at the source instead

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to move all to single point of registration as the inits were everywhere. I get your point now, will revert

Comment thread internal/ent/hooks/listeners_onboarding_program.go Outdated
Comment thread internal/ent/hooks/listeners_onboarding_program.go
Comment thread internal/ent/hooks/listeners_onboarding_program.go Outdated
Comment thread internal/ent/hooks/listeners_onboarding_program.go Outdated
@adelowo
adelowo marked this pull request as draft September 11, 2026 21:45
auto-merge was automatically disabled September 11, 2026 21:45

Pull request was converted to draft

@github-actions github-actions Bot removed the cli label Sep 12, 2026
@adelowo
adelowo marked this pull request as ready for review September 13, 2026 14:53
Comment thread internal/ent/hooks/onboarding.go Outdated
@adelowo
adelowo enabled auto-merge (squash) September 13, 2026 17:22
@sonarqubecloud

Copy link
Copy Markdown

@adelowo
adelowo merged commit a799af5 into main Sep 13, 2026
20 checks passed
@adelowo
adelowo deleted the feat-ISS-2880 branch September 13, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common enhancement New feature or request graphapi

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants